Task #92303

[BUGFIX] Remove unnecessary pre-checks on "transport_spool_filepath"

Added by TYPO3 GmbH TYPO3com 12 days ago. Updated 5 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-09-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions. Even if this fails, there are further writable-checks down the line.

This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/267

Associated revisions

Revision f1bcb7e5 (diff)
Added by Ingo Fabbri 5 days ago

[BUGFIX] Remove pre-checks on "transport_spool_filepath"

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions.
Even if this fails, there are further writable-checks down the line
in \TYPO3\CMS\Core\Mail\FileSpool constructor.

Resolves: #92303
Releases: master, 10.4, 9.5
Change-Id: I4d388ab458455eb1f940e0452fcde07967e1ca67
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748
Reviewed-by: Bernhard Berger <>
Reviewed-by: Benni Mack <>
Reviewed-by: Daniel Goerz <>
Tested-by: Benni Mack <>
Tested-by: Daniel Goerz <>
Tested-by: TYPO3com <>

Revision 835aa21e (diff)
Added by Ingo Fabbri 5 days ago

[BUGFIX] Remove pre-checks on "transport_spool_filepath"

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions.
Even if this fails, there are further writable-checks down the line
in \TYPO3\CMS\Core\Mail\FileSpool constructor.

Resolves: #92303
Releases: master, 10.4, 9.5
Change-Id: I4d388ab458455eb1f940e0452fcde07967e1ca67
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65812
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 9 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748

#2 Updated by Gerrit Code Review 9 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748

#3 Updated by Gerrit Code Review 9 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748

#4 Updated by Gerrit Code Review 9 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748

#5 Updated by Gerrit Code Review 5 days ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65812

#6 Updated by Gerrit Code Review 5 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65813

#7 Updated by Anonymous 5 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF