Task #92557

Use strict in all classes in linkvalidator, add type hints

Added by Sybille Peters 10 days ago. Updated 3 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2020-10-13
Due date:
% Done:

0%

TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Clean up code:

  • Use strict in all classes
  • Add type hints
  • checkLink third argument LinkAnalyzer: this is only used in Linktype "LinkHandler" and is used to pass TSconfig. The lowlevel class / function inherit from AbstractLinktype should propably not depend on LinkAnalyzer. It might be possible to pass the configuration differently, i.e. this is already done in ExternalLinkType::setAdditionalConfig
  • possibly move all queries to the repository class BrokenLinkRepository
  • LinkAnalyzer::init(): second parameter: $pidList: "string|array $pidList List of comma separated page uids in which to search for links, can be an array too": error-prone, use array

History

#1 Updated by Gerrit Code Review 10 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#2 Updated by Sybille Peters 10 days ago

  • Description updated (diff)

#3 Updated by Sybille Peters 10 days ago

  • Description updated (diff)

#4 Updated by Sybille Peters 10 days ago

  • Description updated (diff)

#5 Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#6 Updated by Gerrit Code Review 10 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#7 Updated by Gerrit Code Review 9 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#8 Updated by Gerrit Code Review 9 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#9 Updated by Gerrit Code Review 9 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#10 Updated by Gerrit Code Review 9 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#11 Updated by Gerrit Code Review 8 days ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#12 Updated by Gerrit Code Review 8 days ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#13 Updated by Gerrit Code Review 8 days ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#14 Updated by Gerrit Code Review 5 days ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#15 Updated by Gerrit Code Review 5 days ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#16 Updated by Gerrit Code Review 4 days ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#17 Updated by Gerrit Code Review 4 days ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#18 Updated by Gerrit Code Review 4 days ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

#19 Updated by Gerrit Code Review 3 days ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66133

Also available in: Atom PDF