Project

General

Profile

Actions

Bug #92787

closed

Linkvalidator searches only current page

Added by Michael Sollmann about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2020-11-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In TYPO3 10 the linkvalidator searches only in the current page/level, regardless how much levels are chosen. Tested in 2 independent installations (TYPO3 10.4.6 / 10.4.9).


Files

linkvalidator.png (138 KB) linkvalidator.png Sybille Peters, 2020-11-07 21:39
Actions #1

Updated by Sybille Peters about 4 years ago

I cannot reproduce this in the current 10.4. I did not use latest release, I used the lastst development version from Git, but I am not aware that there were any bugfixes recently that could have fixed this.

How can I reproduce this?

Do you mean there are broken links in subpages but the report shows only links on current page? Did you verify that the broken links have been detected? What happens if you select the subpage? Are the broken links shown?

I am on a page with 4 broken links and a subpage with 1 broken link.

- Linkvalidator test (4 broken links) |
-> subpage (1 broken link)

All 5 broken links are displayed in report (if I select "1 level" or "infinite")

Actions #2

Updated by Sybille Peters about 4 years ago

Tested with 10.4.9. I cannot reproduce it. Please contact me on TYPO3 Slack @sybille

Actions #3

Updated by Sybille Peters about 4 years ago

  • Status changed from New to Needs Feedback
Actions #4

Updated by Michael Sollmann about 4 years ago

I don't use Slack, so I give you some more information here:

Do you mean there are broken links in subpages but the report shows only links on current page?

Yes.

Did you verify that the broken links have been detected?

Yes

What happens if you select the subpage? Are the broken links shown?

Yes

I tested it now on a third v10 system and there it works - as on any other system I used before (7, 8, 9).
Because I use no config options for the linkvalidator and there is no error in my sys_log I have no clue how to find out what the problem is. But the behaviour is reproducible on these two v10 systems mentioned above.

Actions #5

Updated by Sybille Peters about 4 years ago

Thanks for taking the time.

As already pretty obvious before, it looks like the problem is in the linkvalidator report (not in the checking itself).

I will make some suggestions to track this down - I understand if you don't want to put too much time into it, but if I can reproduce the error, I am pretty sure I would be able to fix it.

I might be able to create a "debug version" with some more logging and test output in the next few days.

Alternatively: I understand if you don't want to muck about in the code or debug in production. Also, I don't know if you are a developer, but if you are, you might be able to do this:

1. debug - I don't debug our production site, I usually work on a copy. Debugging this (e.g. with xdebug + PhpStorm) would actually be the fastest way to track down the error. If you could do this and set a breakpoint here you could step through it and might be able to see the problem pretty quickly.

Check the variables:

  • $pages - should be an array of all pages (current page and subpages)
  • $linktypes should be an array ['external', 'db', 'file']
  • $brokenLinks should be an array of all broken links found on current page and subpages

2. You checked the sys_log. Not all is logged in sys_log. Can you also check the logfiles written by the logging framework , found in typo3temp/var/log (non-Composer) or ../var/log (in Composer based installations). (I don't expect this to yield results, but it is worth a try

3. Alternatively you could add log messages with the logging framework.


You can also contact me via email: You can see my email address in the commit messages: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66146/3//COMMIT_MSG

Actions #6

Updated by Michael Sollmann about 4 years ago

Thank you for your explanation how to debug. Today I wanted to check the validator, but the error is gone... Perhaps it has to do with the security update (v10.4.10), which I did yesterday? If the error occurs again, I will report.

Actions #7

Updated by Sybille Peters almost 4 years ago

  • Status changed from Needs Feedback to Closed

That is good news. Let's hope the problem is in fact fixed. I will close now. If you can reproduce it again, we can reopen.

Actions

Also available in: Atom PDF