Project

General

Profile

Actions

Task #92981

closed

Require doctrine/dbal 2.12.0

Added by Benni Mack over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2020-12-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:
Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66971

Actions #2

Updated by Benni Mack over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Jörn Wagner over 3 years ago

Why not also for v10? Would be a big step towards compatibility with PHP 8.

Actions #4

Updated by Benni Mack over 3 years ago

Jörn Wagner wrote in #note-3:

Why not also for v10? Would be a big step towards compatibility with PHP 8.

Hey Jörn,

this is a bit of a bummer. We cannot require Doctrine DBAL 2.12 in TYPO3 v10, because TYPO3 v10 has a minimum PHP version of 7.2, however Doctrine DBAL 2.11+ supports PHP 7.3+. I tried contacting the Doctrine DBAL team and asked if we can support them, but didn't get any feedback (yet).

All the best,
Benni.

Actions #5

Updated by Jörn Wagner over 3 years ago

Benni Mack wrote in #note-4:

Jörn Wagner wrote in #note-3:

Why not also for v10? Would be a big step towards compatibility with PHP 8.

We cannot require Doctrine DBAL 2.12 in TYPO3 v10, because TYPO3 v10 has a minimum PHP version of 7.2, however Doctrine DBAL 2.11+ supports PHP 7.3+.

What about just removing the upper bound so 2.12 can be used? Like "doctrine/dbal": "^2.11" or something. But as I understand, TYPO3 v10 is officially incompatible with PHP 8 so I guess it's okay to just do this in v11.

Actions #6

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF