Project

General

Profile

Actions

Bug #94273

closed

FileSearchDemand / searchFiles searches in sha1-hash

Added by Stefan Weißwange over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2021-06-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I search for files in a storage via

$searchDemand = FileSearchDemand::createForSearchTerm($searchTerm);
$searchResults = $folder->searchFiles($searchDemand);
One $searchTerm is 'd4729', which returns two results:
  • the file I want: 'd4729lbr.pdf'
  • one file I dont want: 'd1566raa.pdf'

I checked the second file, which obviously has another name. The content of this file does not contain the $searchTerm. So I checked sys_file and found the $searchTerm in the sha1-hash (7071623199af3f7564ec1db8e5 d4729 4c339b2aa).

I dont think the search should check the sha1-hash as a default-setting while searching in a storage.

Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69399

Actions #2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69399

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69399

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69433

Actions #5

Updated by Guido Schmechel over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF