Bug #94529: Css class "card" colliding with bootstrap card - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #94529

closed

Css class "card" colliding with bootstrap card

Added by Nikita Hovratov about 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2021-07-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Before the upgrade to bootstrap v5 TYPO3 already introduced the class "card".
Now the bootstrap class is overridden and bootstrap hands over unneeded css properties.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Christoph Schwob almost 3 years ago

Do you mean there are unused, duplexed CSS styles or bugs / wrong stylings in the card components?

Actions

Copy link

Updated by Nikita Hovratov almost 3 years ago

These are two completely different stylings. TYPO3 cards are for example in the admin tools. Bootstrap cards look similar, but they aren't the same. Now the stylings are merged/overridden.

Either we need to exclude bootstrap cards and don't use them at all or rename our own card class to typo3-card or something similar.

Actions

Copy link

Updated by Benni Mack almost 3 years ago

Nikita Hovratov wrote in #note-2:

These are two completely different stylings. TYPO3 cards are for example in the admin tools. Bootstrap cards look similar, but they aren't the same. Now the stylings are merged/overridden.

Either we need to exclude bootstrap cards and don't use them at all or rename our own card class to typo3-card or something similar.

let's rename our cards to "t3-card".

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

#10

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480

Actions

Copy link

#11