Project

General

Profile

Actions

Task #94538

closed

Clarify naming of select renderType selectSingleBox?

Added by Sybille Peters over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2021-07-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Updated, due to comments in review.


To make it easy to choose from existing renderTypes and understand TCA, it is helpful if the naming is intuitive.

For select, we currently have:

  • selectSingle
  • selectSingleBox
  • selectCheckBox
  • selectMultipleSideBySide
  • selectTree

Proposal 1

Original proposal: rename renderType='selectSingleBox' to 'selectMultipleBox'. See comments in review: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69811

It seems the "single" does not refer to the number of items selected, but to the number of elements (boxes).

Proposal 2

Perhaps the documentation can be updated, to make the naming scheme more clear.

See list: https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/Select/Index.html#columns-select

see selectSingleBox:

Renders a select field to select multiple entries from a given list.
The name is misleading. This is a renderType which allows you to select multiple elements!

https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/selectSingleBox.html#columns-select-rendertype-selectsinglebox

Actions #1

Updated by Sybille Peters over 3 years ago

  • Assignee set to Sybille Peters
Actions #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69811

Actions #3

Updated by Sybille Peters over 3 years ago

  • Subject changed from Remove renderType='selectSingleBox' to 'selectMultipleBox' to Rename renderType='selectSingleBox' to 'selectMultipleBox'
Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69811

Actions #5

Updated by Sybille Peters over 3 years ago

  • Subject changed from Rename renderType='selectSingleBox' to 'selectMultipleBox' to Clarify naming of select renderType selectSingleBox?
Actions #6

Updated by Sybille Peters over 3 years ago

  • Description updated (diff)
Actions #7

Updated by Sybille Peters about 3 years ago

  • Status changed from Under Review to Closed

Closing now due to: Too much controversy, not worth the effort.

Actions

Also available in: Atom PDF