Bug #94716

minifyJS is called twice for Inliine JS in Frontend

Added by Benni Mack 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
Start date:
2021-08-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
#1

Updated by Benni Mack 3 months ago

If you have inline JS (or inlineFooterJS) code
the method "GeneralUtility::minifyJavaScript()"
is called twice for the same code to actually minify
the code, because PageRenderer takes
care of minification, so FE process does not
explicitly have to do that.

This does not harm, only if there is a hook
within minifyJavaScript().

Example:
page.config.compressJs = 1
page.config.removeDefaultJS = 0
page.jsInline.10 = TEXT
page.jsInline.10.value (
alert('NOICE');
);

Using xdebug it is obvious that the old way
was calling the method twice.

#2

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70207

#3

Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70207

#4

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70207

#5

Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70207

#6

Updated by Benni Mack 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF