Bug #95411: Fix the generics of ObjectManager and ObjectManagerInterface - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #95411

closed

Fix the generics of ObjectManager and ObjectManagerInterface

Added by Oliver Klee over 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Extbase

Target version:

Start date:

2021-09-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In my projects, PHPStan complains where I use an ObjectManagerInterface in my tests:

24     PHPDoc tag @var for variable $objectManagerStub contains generic interface TYPO3\CMS\Extbase\Object\ObjectManagerInterface but does not specify its types: T  
         You can turn this off by setting checkGenericClassInNonGenericObjectType: false in your phpstan.neon.

The generics annotations of the interface seem to be incorrect. Fix coming up.

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71382

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71382

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71382

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71382

Actions

Copy link

Updated by Oliver Klee over 2 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 37534f083ce685893a73d6a867279bc4c759ce0c.

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71355

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71355

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71465

Actions

Copy link