Bug #97423

WorkspaceRecord cannot be XCLASSed

Added by Oliver Klee 3 months ago. Updated 14 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
12 LTS
Start date:
2022-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Related issues

Related to TYPO3 Core - Epic #97419: Reduce PHPStan warnings in workspacesAccepted2022-04-18

Actions
Related to TYPO3 Core - Feature #97754: Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecordNew2022-06-09

Actions
#1

Updated by Oliver Klee 3 months ago

  • Related to Epic #97419: Reduce PHPStan warnings in workspaces added
#2

Updated by Oliver Klee 3 months ago

  • Subject changed from Unsafe use of new static in WorkSpaceRecord to Unsafe use of new static in WorkspaceRecord
#3

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#4

Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#5

Updated by Oliver Klee 24 days ago

  • Related to Feature #97754: Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecord added
#6

Updated by Gerrit Code Review 24 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#7

Updated by Oliver Klee 23 days ago

  • Subject changed from Unsafe use of new static in WorkspaceRecord to WorkspaceRecord cannot be XCLASSed

WorkspaceRecord::get() creates new instances of WorkspaceRecord with "new" instead of with "makeInstance". This breaks XCLASSing of this class.

#8

Updated by Gerrit Code Review 23 days ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#9

Updated by Gerrit Code Review 22 days ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#10

Updated by Gerrit Code Review 16 days ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#11

Updated by Gerrit Code Review 14 days ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

#12

Updated by Gerrit Code Review 14 days ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74960

#13

Updated by Oliver Klee 14 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF