Project

General

Profile

Actions
Copy link

Bug #97423

closed

WorkspaceRecord cannot be XCLASSed

Added by Oliver Klee over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
12 LTS
Start date:
2022-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Related issues 2 (1 open — 1 closed)

Related to TYPO3 Core - Epic #97419: Reduce PHPStan warnings in workspacesClosed2022-04-18

Actions
Related to TYPO3 Core - Feature #97754: Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecordNew2022-06-09

Actions
Actions
Copy link
 #1

Updated by Oliver Klee over 2 years ago

  • Related to Epic #97419: Reduce PHPStan warnings in workspaces added
Actions
Copy link
 #2

Updated by Oliver Klee over 2 years ago

  • Subject changed from Unsafe use of new static in WorkSpaceRecord to Unsafe use of new static in WorkspaceRecord
Actions
Copy link
 #3

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #4

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #5

Updated by Oliver Klee over 2 years ago

  • Related to Feature #97754: Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecord added
Actions
Copy link
 #6

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #7

Updated by Oliver Klee over 2 years ago

  • Subject changed from Unsafe use of new static in WorkspaceRecord to WorkspaceRecord cannot be XCLASSed

WorkspaceRecord::get() creates new instances of WorkspaceRecord with "new" instead of with "makeInstance". This breaks XCLASSing of this class.

Actions
Copy link
 #8

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #9

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #10

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #11

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74347

Actions
Copy link
 #12

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74960

Actions
Copy link
 #13

Updated by Oliver Klee over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #14

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF