Project

General

Profile

Actions

Bug #97469

closed

PageCopy with nested ContentElements(GridElements) l10n_source is set to uid of translated Element of old page

Added by Alex Ebeling-Hoppe over 2 years ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2022-04-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

Preconditions:
The TYPO3 10.x installation is set up as multilang installation.
The source page uses an indent container (gridelements) with at least one content element.
The page and its content is translated with "Free Mode".

Steps to reproduce the error:
The source page is copied and pasted. Let's call the new page target page. While looking on the database all translated records within the indent container have set l10n_source to the UIDs of the translated Content Elements of the source page.

That is wrong. Expected behaviour would be the l10n_source set to the uids of the corresponding CEs on the target page.

I think, i've found a solution:

In DataHandling/DataHandler func copySpecificPage the order of processing elements is done reverse.
So that means that on the target page all translated elements are created before the original elements are present.
Thats why it is impossible to set the correct l10n_source at that time.

I've switched to ASC ordering and it looks good.

I'll try to push a patch of my modification.

BW
Alex


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #91752: Recursive Copy: Translation is created before Original PageResolved2020-07-06

Actions
Has duplicate TYPO3 Core - Task #97470: [BUGFIX] PageCopy with nested ContentElements(GridElements) l10n_source is set to uid of translated Element of old pageClosed2022-04-25

Actions
Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74391

Actions #2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74391

Actions #3

Updated by Oliver Bartsch over 2 years ago

  • Has duplicate Task #97470: [BUGFIX] PageCopy with nested ContentElements(GridElements) l10n_source is set to uid of translated Element of old page added
Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74391

Actions #5

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74391

Actions #6

Updated by Benni Mack about 2 months ago

  • Status changed from Under Review to New
Actions #7

Updated by Benni Mack about 2 months ago

  • Related to Bug #91752: Recursive Copy: Translation is created before Original Page added
Actions #8

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87452

Actions #9

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87452

Actions #10

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87452

Actions #11

Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87452

Actions #12

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87506

Actions #13

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87507

Actions #14

Updated by Benni Mack about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87507

Actions #16

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87507

Actions #17

Updated by Benni Mack about 1 month ago

  • Status changed from Under Review to Resolved
Actions

Also available in: Atom PDF