Task #97858: Improve type annotations regarding storage folder names - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #97858

closed

Improve type annotations regarding storage folder names

Added by Oliver Klee almost 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Code Cleanup

Target version:

12 LTS

Start date:

2022-07-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Storage folder names can also be int-like string, which causes them to be autoconverted to ints when used as array key. This recently has lead to a bug. We should make our code more explicit to help static code analysis and devs avoid this problem in the future.

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033

Actions

Copy link

Updated by Oliver Klee almost 2 years ago

Related to Bug #97851: 11.5.13-dev: prepareFolderInformation(): Argument #2 ($alternativeName) must be of type ?string, int given added

Actions

Copy link

Updated by Oliver Klee almost 2 years ago

Related to Task #97711: Improve the return type annotation of ListUtility::resolveSpecialFolderNames added

Actions

Copy link

Updated by Oliver Klee almost 2 years ago

Blocked by Task #97859: Annotate that methods from InaccessibleFolder never return added

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75059

Actions

Copy link

#10