Bug #98116
open
History rollback with mixed data
0%
Description
When you perform a history rollback containing insert/deletes and just changed records, the rollback does only rollback insert/deletes. It does not rollback changed records.
Bug possibly introduced here: https://github.com/TYPO3/typo3/commit/2b347709fc9edcd2435698e2794562153cccfef2
Files
Updated by Anonymous about 2 years ago
- Related to Bug #81649: Undo delete of CE throws exception added
Updated by Gerrit Code Review about 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411
Updated by Stefan Bürk about 2 years ago
Maybe I'm too stupid, but can not reproduce this with current main. Can you please provide a step by step introduction to reproduce this (for me) ?
Updated by Anonymous about 2 years ago
You need to have "changed records" and ("newly inserted" or "deleted records") in the "rollback-batch".
Result: only insert/deletes are rolled back. The "changed" records are not rolled back.
Updated by Anonymous about 2 years ago
But I can provide a (rather stupid) step by step guide:
- create page
- create "text" content element (UID: 1)
- give it a header "foo" and a subheader "bar"
- create "image" content element (UID: 2)
- assign it some image file
- create "textimage" content element (UID: 3)
- give it a header "baz" and a subheader "qux" and some image
- delete CE 1 and 2
- change "header" of UID:3 to "hello world"
Now visit page history. Show all sub-children-records.
Now revert the deletion of UID:1 & UID:2 and the header-modification on UID:3.
Do this with "rollback all changes shown"-button. Do not use the "rollback single record"-button!
see image attachment https://forge.typo3.org/attachments/37027
Expected result: UID:3 "header" is "baz" again.
Actual result: UID:3 "header" remains "hello world"
see image attachment https://forge.typo3.org/attachments/37028
Updated by Anonymous about 2 years ago
Feel free to update the patch commit message. I had no muse.
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411
Updated by Gerrit Code Review about 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411
Updated by Gerrit Code Review about 1 year ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411