Project

General

Profile

Actions

Bug #98116

open

History rollback with mixed data

Added by Anonymous over 1 year ago. Updated 8 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-08-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

When you perform a history rollback containing insert/deletes and just changed records, the rollback does only rollback insert/deletes. It does not rollback changed records.

Bug possibly introduced here: https://github.com/TYPO3/typo3/commit/2b347709fc9edcd2435698e2794562153cccfef2


Files

image.png (42.2 KB) image.png Anonymous, 2022-08-10 15:04
image.png (85.5 KB) image.png Anonymous, 2022-08-10 15:05

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81649: Undo delete of CE throws exceptionClosed2017-06-21

Actions
Actions #1

Updated by Anonymous over 1 year ago

  • Related to Bug #81649: Undo delete of CE throws exception added
Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions #3

Updated by Stefan Bürk over 1 year ago

Maybe I'm too stupid, but can not reproduce this with current main. Can you please provide a step by step introduction to reproduce this (for me) ?

Actions #4

Updated by Anonymous over 1 year ago

You need to have "changed records" and ("newly inserted" or "deleted records") in the "rollback-batch".

Result: only insert/deletes are rolled back. The "changed" records are not rolled back.

Updated by Anonymous over 1 year ago

But I can provide a (rather stupid) step by step guide:

  1. create page
  2. create "text" content element (UID: 1)
  3. give it a header "foo" and a subheader "bar"
  4. create "image" content element (UID: 2)
  5. assign it some image file
  6. create "textimage" content element (UID: 3)
  7. give it a header "baz" and a subheader "qux" and some image
  8. delete CE 1 and 2
  9. change "header" of UID:3 to "hello world"

Now visit page history. Show all sub-children-records.
Now revert the deletion of UID:1 & UID:2 and the header-modification on UID:3.
Do this with "rollback all changes shown"-button. Do not use the "rollback single record"-button!

see image attachment https://forge.typo3.org/attachments/37027

Expected result: UID:3 "header" is "baz" again.

Actual result: UID:3 "header" remains "hello world"

see image attachment https://forge.typo3.org/attachments/37028

Actions #6

Updated by Anonymous over 1 year ago

Feel free to update the patch commit message. I had no muse.

Actions #7

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions #8

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions #9

Updated by Gerrit Code Review 12 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions #10

Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions #11

Updated by Gerrit Code Review 8 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75411

Actions

Also available in: Atom PDF