Feature #83847
Updated by Sybille Peters over 4 years ago
This change will improve the workflow for editors, who fix broken links.
In the reports view you can click on the pencil to edit the record. If you edit and close, the backend will automatically jump back to the Report view. If the broken link was fixed, I would expect it to be removed from the list of broken links.
This is currently not the case. It makes fixing links very tedious in case you have several because you have to keep switching to the "Check links" tab and recheck.
And use flashmessage.
h2. Reproduce
# Create 3 broken links in the body text of a content element (e.g. text & media)
# Info > Linkvalidator > Check links (current page, check all link types)
# Switch to "Report" tab. You should see 3 broken links in list
# click on pencil icon to edit the record.
# Remove one of the broken links
# click on save and close
h2. Expected Result
You should now see only 2 broken links in list
h2. Actual Result
There are still 3 broken links. You must go back to "Check links" tab and check again.
!linkvalidator.png!
h2. Possible solutions
When the editor edits, only a specific field of a record gets editied, e.g. tt_content.bodytext or pages.url.
# Recheck if the broken link that the editor clicked on is still in the field that was just edited. If not, remove it from list
# Recheck all links in record / field that was just edited. Update the list
# Change visual appearance of all broken links corresponding to edited record (e.g. dim it) to indicate that we are currently not sure if links are still broken. Display an icon to recheck broken links. This will default to behaviour 1 or 2
Optionally, make this configurable.
Ideally, we should decided to use one of the above implementations. But this is something that should probably be tested some more in the real world. So implementing all 3 or 2 or the above and making it configurable might not be such a bad idea.
Additionally, we should consider:
* for number 2 (recheck of all links in record): There may be a large number of links. External link checking may have delays. The timeout is currently set to 10. So if we have slow external webpages or there are problems, a recheck may take 30 seconds or more (as worst case). So, this is probably something we want to do asynchronously. But then we don't have the refreshing of the list.