Bug #100040
closedProperly validate start module
100%
Description
BackendController::getStartupModule()
checks for the 'startModule' incorrectly. The code is:
} elseif ($this->moduleLoader->checkMod($beUser->uc['startModule'] ?? '') !== 'notFound') { $startModule = $beUser->uc['startModule'];
Method checkMod
can return string, bool or array. Only array means that that the module exists and available. String and bool (which can only be false
) mean that the module should not be used. Therefore the check should be like:
} elseif (is_array($this->moduleLoader->checkMod($beUser->uc['startModule'] ?? ''))) { $startModule = $beUser->uc['startModule'];
Updated by Thomas Hohn over 1 year ago
- Assignee set to Thomas Hohn
- Target version set to Candidate for patchlevel
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77975
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77975
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77975
Updated by Thomas Hohn over 1 year ago
- Subject changed from startModule validation is incorrect to Properly validate start module
Updated by Thomas Hohn over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8d6c0581ce6a83a4aaee09ffdb6dde7e62287ff4.