Project

General

Profile

Actions

Task #100082

open

Improve performance of PageLinkBuilder

Added by Christian Eßl about 1 year ago. Updated 7 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Frontend
Start date:
2023-03-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

On pages with many links, the PageLinkBuilder can become pretty resource-intensive:

- Because we don't know, which site or page tree the target page belongs to, we first need to fetch the $site object with $siteFinder->getSiteByPageId().
- Internally, this function then needs to recursively fetch the rootline, the target page uid belongs to.
- This needs to be done for every new page id, that we create a link for.

However, on single-site setups, we don't need all this and can safely pass the rootline array, that has already been established in $tsfe. This simple check can save many unnecessary db requests at least for single-site setups.


Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Task #100378: Prevent rootline lookup SQL queries in PageLinkBuilderUnder Review2023-10-09

Actions
Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #6

Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #7

Updated by Christoph Lehmann about 1 year ago

  • Related to Task #100378: Prevent rootline lookup SQL queries in PageLinkBuilder added
Actions #8

Updated by Gerrit Code Review 8 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions #9

Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78024

Actions

Also available in: Atom PDF