Project

General

Profile

Actions

Task #100135

closed

Remove cookieWarning in ext:felogin

Added by Torben Hansen about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2023-03-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The extension uses $GLOBALS['TSFE']->fe_user->isCookieSet() to determine, if a cookie warning message will be shown or not. The message is however never shown, since in a scenario, where the user login was successful, the isCookieSet() method will always return true, since AbstractUserAuthentication will return a cookie in the response to the client.

For TYPO3 12, the request token check will not even authenticate the user, if the pre-session cookie is not present. So ext:felogin will basically never know, if authentication was successful but cookies are disabled.

I could verify, that this feature is also broken in the legacy plugin of ext:felogin (tested TYPO3 8.7 - 10.4).

Since the current "cookie waring" in ext:felogin does not work and can not be fixed easily, it is best to remove it completely and rely on the default message shown, when the login was not successful. This message includes a hint, that authentication was not successful, either caused by wrong credentials or because of disabled cookies.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #99710: EXT:felogin - Show Cookie Warning doesn't workClosedTorben Hansen2023-01-25

Actions
Actions #1

Updated by Torben Hansen about 1 year ago

  • Related to Bug #99710: EXT:felogin - Show Cookie Warning doesn't work added
Actions #2

Updated by Torben Hansen about 1 year ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78089

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78089

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78089

Actions #6

Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78089

Actions #7

Updated by Torben Hansen about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF