Bug #100281
closedPassing number-only properties to form field ViewHelpers causes exception
100%
Description
We're currently upgrading Powermail to version 12 and encountered an issue with form fields if the property passed to it is a int instead of (expectedly) a string. This worked in versions before 12.
Here's the template causing the issue (this repository is not the v12 version yet, but the template is identical)
https://github.com/einpraegsam/powermail/blob/develop/Resources/Private/Partials/Output/Search.html#L33
This triggers following exception in AbstractFormFieldViewHelper
explode(): Argument #2 ($string) must be of type string, int given
In regards of typing, this behaviour makes sense and I'd personally even say that number-only form properties are an edge case, but it still massively breaks this part of the extension.
Explicitly typecasting the usages of the property argument in AbstractFormFieldViewHelper solves this.
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78294
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78294
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78294
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78573
Updated by Benni Mack over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9a6fc9a6f60371e7447d30b83e009a96a1fd7ea8.