Bug #100929
closedTyposcript config controlsList=nodownload not possible!
100%
Description
Typoscript config not possible:
lib.contentElement.settings.media.additionalConfig.controlsList=nodownload
rendering will give 2 attributes
<video .... controlsList controlsList="nodownload"><source src="...." type="video/mp4"></video>
Reason is a doublet Foreach in \TYPO3\CMS\Core\Resource\Rendering\VideoTagRenderer::render-Method
if (isset($options['additionalConfig']) && is_array($options['additionalConfig'])) { foreach ($options['additionalConfig'] as $key => $value) { if ((bool)$value) { $attributes[] = htmlspecialchars($key); } } } foreach (['class', 'dir', 'id', 'lang', 'style', 'title', 'accesskey', 'tabindex', 'onclick', 'controlsList', 'preload'] as $key) { if (!empty($options[$key])) { $attributes[] = $key . '="' . htmlspecialchars($options[$key]) . '"'; } }
Updated by Heiko Dietrich over 1 year ago
Easiest solution couldt be, if use:
$attributes[$key] = ...
instead of
$attributes[] = ...
Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615
Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638
Updated by Benni Mack over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset dc06661c1c3b6fafce8b351496d889814d707f86.
Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638
Updated by Benni Mack over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 96877af6a713f4db45b0e452ea5e601d1c281ee1.