Project

General

Profile

Actions

Task #101529

closed

Use relative paths for test fixture files

Added by Anja Leichsenring 12 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2023-08-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Description

functional tests heavily use a feature to import and compare DB records via CSV files. Those files should be referenced by a syntax consisting of __DIR__ . '...' to enable direct jumping of IDEs and also serve as a clean read.
Some of the CSV fixtures are loaded via 'typo3/sysext/....' paths, which will not offer those benefits.
Find the occurences and replace the relative patch with the __DIR__ syntax.

Functions to look for are
- $this->assertCSVDataSet()
- $this->importCSVDataSet()

Have for example a look into typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php for the wanted syntax, here we corrected the pathes already.

Actions #1

Updated by Anja Leichsenring 12 months ago

  • Description updated (diff)
Actions #2

Updated by Stephan Jorek 12 months ago

What about $this->setUpFrontendRootPage() calls? Looks like they should be replaced too. Will look at it, and give feedback on those calls in the review …

Actions #3

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions #4

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions #5

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions #6

Updated by Gerrit Code Review 12 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions #7

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions #8

Updated by Gerrit Code Review 12 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions #9

Updated by Gerrit Code Review 12 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions #10

Updated by Gerrit Code Review 12 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions #11

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80384

Actions #12

Updated by Stephan Jorek 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF