Bug #101721
closedTelephoneLinkHandler should allow commas and other pause characters
100%
Description
I'm requesting an enhancement for the asString function in the TelephoneLinkHandler class (TYPO3\CMS\Core\LinkHandling). I suggest adding support for pause characters like commas (,) and semi-colons (;) when generating phone links.
This enhancement is crucial for linking phone numbers with extensions, especially for scenarios involving automated systems and PIN inputs.
Adjust the existing regex pattern in TelephoneLinkHandler as follows:
Current Regex Pattern:
/(?:[^\d\+]+)/
Suggested Regex Pattern:
/(?:[^\d\+,;]+)/
This enhancement will provide more flexibility in generating telephone links to accommodate various dialing scenarios in different countries and systems.
Updated by Markus Klein over 1 year ago
Sure, go ahead. Please push the suggested change to our review system.
https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80622
Updated by Dominic Petit over 1 year ago
Markus Klein wrote in #note-1:
Sure, go ahead. Please push the suggested change to our review system.
https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/
Here it is, its my first contribution so I hope I did everything properly.
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80654
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80655
Updated by Dominic Petit about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset fc59d590465add8957271b90f03911b7129e6ce2.