Project

General

Profile

Actions

Bug #101721

closed

TelephoneLinkHandler should allow commas and other pause characters

Added by Dominic Petit 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2023-08-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I'm requesting an enhancement for the asString function in the TelephoneLinkHandler class (TYPO3\CMS\Core\LinkHandling). I suggest adding support for pause characters like commas (,) and semi-colons (;) when generating phone links.
This enhancement is crucial for linking phone numbers with extensions, especially for scenarios involving automated systems and PIN inputs.
Adjust the existing regex pattern in TelephoneLinkHandler as follows:
Current Regex Pattern:


/(?:[^\d\+]+)/

Suggested Regex Pattern:

/(?:[^\d\+,;]+)/

This enhancement will provide more flexibility in generating telephone links to accommodate various dialing scenarios in different countries and systems.

Actions #1

Updated by Markus Klein 9 months ago

Sure, go ahead. Please push the suggested change to our review system.

https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/

Actions #2

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80622

Actions #3

Updated by Dominic Petit 9 months ago

Markus Klein wrote in #note-1:

Sure, go ahead. Please push the suggested change to our review system.

https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/

Here it is, its my first contribution so I hope I did everything properly.

Actions #4

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80654

Actions #5

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80655

Actions #6

Updated by Dominic Petit 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF