Project

General

Profile

Actions

Bug #101728

closed

Epic #99669: CKEditor5 Collection

CKEditor5: softhyphens and source editing mode

Added by Georg Tiefenbrunn 9 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2023-08-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The softhyphen button is still active if switched to source editing mode.
If clicked in source editing mode, a softhyphen is added to the first element.

1. As an editor, I'd either expect the button to be disabled or to insert a softhyphen entity at the current cursor position.

2. As an editor, I'd expect softhyphens to be visible also in source editing mode (shy, #173).

3. As an integrator, I'd like softhyphens to be stored as entities (shy, #173).

4. The button has no tooltip (see @ckeditor/ckeditor5-ui/src/button/button::tooltip). As an editor, I either need a tooltip or button text to identify the button action. Bold and Italic both have the assigned shortcut - "Bold (⌘B)" and "Italic (⌘I)" on macOS - added to the tooltip.

5. Activating the button focuses the button and removes the cursor from the content section. As an editor, I'd expect the cursor to be placed after the inserted value as in all other commands (bold, italic, etc.). If the action is applied to a selection, I would expect the selection still intact.

Actions #1

Updated by Georg Tiefenbrunn 9 months ago

  • Description updated (diff)
Actions #2

Updated by Georg Tiefenbrunn 9 months ago

Actions #3

Updated by Georg Tiefenbrunn 9 months ago

  • Description updated (diff)
Actions #4

Updated by Benjamin Franzke 8 months ago

  • Parent task set to #99669
Actions #5

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #6

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #7

Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #8

Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #9

Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #10

Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #11

Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #12

Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296

Actions #13

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81337

Actions #14

Updated by Anonymous 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF