Project

General

Profile

Actions

Bug #102001

closed

ModifyUrlForCanonicalTagEvent misses the current request or information about the page

Added by Benni Mack 9 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
SEO
Start date:
2023-09-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #99807: Initial url for ModifyUrlForCanonicalTagEventResolved2023-02-03

Actions
Actions #1

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #2

Updated by Benni Mack 9 months ago

  • Related to Bug #99807: Initial url for ModifyUrlForCanonicalTagEvent added
Actions #3

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #4

Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #5

Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #6

Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #7

Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81164

Actions #8

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82021

Actions #9

Updated by Benni Mack 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Philipp Parzer 6 months ago

Minor Update breaks now on TYPO3 Instances that extend generate() function from CanonicalGenerator

Actions #11

Updated by Benni Mack 6 months ago

Philipp Parzer wrote in #note-10:

Minor Update breaks now on TYPO3 Instances that extend generate() function from CanonicalGenerator

Yes. The class is marked as internal, and XCLASS isn't covered by the backwards-compatibility. Also, there is a PSR-14 event directly in this class, can you elaborate why you needed to extend this class in the first place?

Could you fix this in your project or is your use-case a common scenario for people to extend this class?

Actions

Also available in: Atom PDF