Project

General

Profile

Actions

Task #102148

closed

Epic #101608: File Abstraction Layer Changes for v13

Cleanup GifBuilder code

Added by Benni Mack 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Image Generation / GIFBUILDER
Target version:
Start date:
2023-10-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This change avoids using the $this->im
property which is the resource pointer to the
\GdImage object.

In addition, the method gifBuild() is the only place
to deal with absolute path and the actual path
prefix, making fileName() easier to understand.

This change will then allow to advance with
Gdlib, adding support for webp at the next stage.

Actions #1

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81414

Actions #2

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81414

Actions #3

Updated by Benni Mack 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF