Project

General

Profile

Actions

Task #102240

closed

Pin to PER Coding Style v1.0

Added by Benjamin Franzke about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Start date:
2023-10-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27
in order to implement the new rules that are defined in
PER Coding Style 2.0 [1]. The alias PER has been pointed to
PER-CS2.0 although the current set of rules are not finished yet. [2]
There is only one rule (single_line_empty_body) that is done by now
and more will follow, so we rather pin to PER-CS1.0 for now (and
enable single_line_empty_body which we already migrated to) in
order to prevent having coding style changes with every
php-cs-fixer raise. We rather wait until the 2.0 preset has been
finished and is on par with the upstream php-fig definitions and
switch to it with one change.

[1] https://www.php-fig.org/per/coding-style/
[2] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7247


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #102236: Bump friendsofphp/php-cs-fixer:^3.35.1Closed2023-10-24

Actions
Actions #1

Updated by Benjamin Franzke about 1 year ago

  • Related to Task #102236: Bump friendsofphp/php-cs-fixer:^3.35.1 added
Actions #2

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81534

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81553

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81539

Actions #5

Updated by Anonymous about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF