Project

General

Profile

Actions

Task #102275

closed

Catch exception and return new instance of ContentObjectRenderer

Added by TYPO3 GmbH TYPO3com about 1 year ago. Updated 21 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2023-10-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

If there was no "currentContentObject" set in the request, the new instance of ContentObjectRenderer was never reached and lead to an exception

This issue was automatically created from https://github.com/TYPO3/typo3/pull/466

Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81599

Actions #2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81599

Actions #3

Updated by Stefan Bürk about 1 year ago

Mhh - `NoSuchArgumentException` is through when an "Extbase Attribute" is requestes which does not exists.

However, requesting an attribute on the request object, even if it is a "Extbase Request" dispatches it to the PSR-7 event.

Without further information I would say, that a overriden "Extbase Request" from old times by custom or 3rd party extension is passed in, not reflect the changes done for TYPO3 v12 on the extbase request stuff.

Therefore, this is an issue of the not aligned xclassed/extended extbase request. That should properly avoid the extbase attribute retrival with getAttribute() and adopt the getExtbaseAttribute() instead.

This is comapt code, and hiding the issue of 3rd party code not aligned to TYPO3 v12 code is the charge of the code extending it.

I do not see the core in charge to add a additional try {} here not possible with pure core usage. The extending extension need to fix this, not the core.

Actions #4

Updated by Benni Mack 21 days ago

  • Status changed from Under Review to Closed

Closing this one due to lack of feedback here.

Actions

Also available in: Atom PDF