Bug #102328
closedRegression in cObjGet
100%
Description
Reported by Rafael Kähm in https://forge.typo3.org/issues/99503#note-13
Please reopen, because applied patch makes unnecessary BC at least on 11.5.
See:
public function cObjGet($setup, $addKey = '')
{
return implode('', $this->cObjGetSeparated($setup, $addKey));
}
public function cObjGetSeparated(?array $setup, string $addKey = ''): array
{
if (!is_array($setup) || $setup === []) {
return [];
}
Proposal:
public function cObjGet($setup, $addKey = '')
{
if (!is_array($setup)) {
return '';
}
return implode('', $this->cObjGetSeparated($setup, $addKey));
}
public function cObjGetSeparated(?array $setup = [], string $addKey = ''): array
{
if (empty($setup)) {
return [];
}
}
Updated by Benjamin Franzke about 1 year ago
- Related to Bug #99503: Inline script concatenation requires scripts to have trailing ";" added
Updated by Benjamin Franzke about 1 year ago
Shouldn't happen in real installations thanks to https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L1855-L1870
but in can happen with test mocks/setups:
https://github.com/TYPO3-Solr/ext-solr/actions/runs/6771688714/job/18402674066#step:12:118
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81698
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81661
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81662
Updated by Anonymous about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 222367c6a86dfe341fb4111ae67da56aa50cb912.