Project

General

Profile

Actions

Task #102503

closed

Revert "Respect not-nullable strings in `TableBuilder`"

Added by Stefan Bürk 12 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2023-11-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

#102495 ensured that the `ext_tables.sql` scanning using
the own sql parser set column comments to an empty string
instead of using the default of null.

This has been done as a preparation for the next Doctrine
DBAL major version upgrade.

Due to the fact that the doctrine `Column` does not contain
the "string" enforcement this now means that empty comments
are detected as changes for PostgreSQL.

It does not make sense to extend and replace all the classes
of doctrine to reflect the upcoming changes, therefore this
change is reverted.

The original intention needs to be included with the major
Doctrine DBAL upgrade.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #102495: Respect not-nullable strings in `TableBuilder`ClosedStefan Bürk2023-11-23

Actions
Actions #1

Updated by Stefan Bürk 12 months ago

  • Related to Task #102495: Respect not-nullable strings in `TableBuilder` added
Actions #2

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81902

Actions #3

Updated by Stefan Bürk 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF