Bug #102602
closedTime input does not initialize 00:00 properly
100%
Description
The time input does not properly load the time 00:00. When the field is required, it is marked as error after reloading the record.
This prevents a valid record to be saved.
Steps to reproduce¶
- Create record in the backend
- Set time to
00:00
- Save form
Results¶
- Expected result: Input has the time
00:00
- Actual result: the input is unset and the input field has an error (since required)
TCA¶
'columns' => [
'mytime' => [
'label' => 'mytime',
'config' => [
'type' => 'datetime',
'format' => 'time',
'default' => 0,
'required' => true,
'nullable' => false,
],
],
],
Cause¶
This bug was introduced in TYPO3 v12. In previous version, the time was set to 00:00.
It was introduced by the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/79793
Possible fixes¶
This bug could be fixed in one of these places by removing the equals 0 checks
a) Form/Element/DatetimeElement
b) TypeScript/backend/form-engine-validation.ts
I think the better place is a), since all times are then returned as 1970-01-01T00:00:00Z
. Whereas now, 0 is the exception.
Files
Updated by Imko Schumacher 9 months ago
- Related to Bug #101258: FormEngine date field doesn't accept 00:00 01-01-1970 added
Updated by Gerrit Code Review 9 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 7 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 4 months ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 2 months ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093
Updated by Gerrit Code Review 2 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84459
Updated by Gerrit Code Review 2 months ago
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84459
Updated by Imko Schumacher 2 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b3326bd09a7034c2f47c3b5e9f0af7e82bd45564.