Project

General

Profile

Actions

Bug #102692

closed

Avoid type errors in `ResourceFactory` methods

Added by Stefan Bürk 7 months ago. Updated 8 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2023-12-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With #92289 logic has been decoupled from `ResourceFactory`
into the `StorageRepository`. As a side change, native php
typeing has been added to a couple of methods.

`StorageRepository->findByUid()` paramter type has been set
to integer, which breaks the `null` fallback and retrieving
the default storage `uid: 0` in `ResourceFactory` method
`getStorageObjectFromCombinedIdentifier()`. Even worser is
the fact that `getObjectFromCombinedIdentifier()` does not
even try to cope with a invalid provided identifier.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #92289: Decouple logic of ResourceFactory into StorageRepositoryClosedBenni Mack2020-09-11

Actions
Actions #1

Updated by Stefan Bürk 7 months ago

  • Related to Task #92289: Decouple logic of ResourceFactory into StorageRepository added
Actions #2

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82203

Actions #3

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82203

Actions #4

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82232

Actions #5

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82233

Actions #6

Updated by Stefan Bürk 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack 8 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF