Bug #103389
closed
Multiple configured coverAreas not correctly displayed in image manipulation modal
100%
Description
The following cover areas are defined in a custom page field:
'columns' => [
'crop' => [
'config' => [
'cropVariants' => [
'desktop_wide' => [
'title' => 'Desktop wide',
'allowedAspectRatios' => [
'default' => [
'title' => 'Default',
'value' => 1920 / 680,
],
],
'selectedRatio' => 'default',
'coverAreas' => [
[
'x' => 0,
'y' => 0,
'width' => 1,
'height' => 0.25,
],
[
'x' => 0.2,
'y' => 0.35,
'width' => 0.25,
'height' => 0.5,
],
],
],
'desktop' => [
'title' => 'Desktop',
'allowedAspectRatios' => [
'default' => [
'title' => 'Default',
'value' => 1370 / 680,
],
],
'selectedRatio' => 'default',
'coverAreas' => [
[
'x' => 0,
'y' => 0,
'width' => 1,
'height' => 0.25,
],
[
'x' => 0.08,
'y' => 0.35,
'width' => 0.45,
'height' => 0.5,
],
],
],
'small' => [
'title' => 'Tablet / Smartphone',
'allowedAspectRatios' => [
'default' => [
'title' => 'Default',
'value' => 16 / 9,
],
],
'selectedRatio' => 'default',
],
],
],
],
],
However, the cover areas in the UI are displayed like that:
Desktop wide:
Desktop:
Tablet/Smartphone:
Mind the duplicated cover areas, best seen in "Desktop wide" and "Desktop" for the second defined cover area. Additionally, the "Tablet/Smartphone" crop variant should have no cover areas displayed.
It looks like all defined cover areas are combined for each crop variant.
TYPO3 v12.4.12
Files
Updated by Chris Müller 9 months ago
In the payload of the "Open Editor" button the cover areas are passed correctly:
{
"cropVariants": {
"desktop_wide": {
"id": "desktop_wide",
"title": "Desktop wide",
"cropArea": {
"x": 0,
"y": 0.10170383527399512,
"width": 1,
"height": 0.6296296296296295
},
"allowedAspectRatios": {
"default": {
"id": "default",
"title": "Default",
"value": 2.823529411764706
}
},
"selectedRatio": "default",
"focusArea": null,
"coverAreas": [
{
"x": 0,
"y": 0,
"width": 1,
"height": 0.25
},
{
"x": 0.2,
"y": 0.35,
"width": 0.25,
"height": 0.5
}
]
},
"desktop": {
"id": "desktop",
"title": "Desktop",
"cropArea": {
"x": 0,
"y": 0.00018511075673567726,
"width": 1,
"height": 0.8824006488240065
},
"allowedAspectRatios": {
"default": {
"id": "default",
"title": "Default",
"value": 2.014705882352941
}
},
"selectedRatio": "default",
"focusArea": null,
"coverAreas": [
{
"x": 0,
"y": 0,
"width": 1,
"height": 0.25
},
{
"x": 0.08,
"y": 0.35,
"width": 0.45,
"height": 0.5
}
]
},
"small": {
"id": "small",
"title": "Tablet \/ Smartphone",
"cropArea": {
"x": 0,
"y": 0,
"width": 1,
"height": 1
},
"allowedAspectRatios": {
"default": {
"id": "default",
"title": "Default",
"value": 1.7777777777777777
}
},
"selectedRatio": "default",
"focusArea": null,
"coverAreas": null
}
},
"image": 4908
}
Updated by Chris Müller 9 months ago
· Edited
Initially, for "Desktop wide" in HTML three cover areas are defined instead of the two configured:
<div class="cropper-cover-area t3js-cropper-cover-area" style="height:50%;left:20%;top:35%;width:25%;"></div> <div class="cropper-cover-area t3js-cropper-cover-area" style="height:25%;left:0%;top:0%;width:100%;"></div> <div class="cropper-cover-area t3js-cropper-cover-area" style="height:50%;left:8%;top:35%;width:45%;"></div>
After switching to "Desktop" four are defined:
<div class="cropper-cover-area t3js-cropper-cover-area" style="height:25%;left:0%;top:0%;width:100%;"></div> <div class="cropper-cover-area t3js-cropper-cover-area" style="height:50%;left:20%;top:35%;width:25%;"></div> <div class="cropper-cover-area t3js-cropper-cover-area" style="height:25%;left:0%;top:0%;width:100%;"></div> <div class="cropper-cover-area t3js-cropper-cover-area" style="height:50%;left:8%;top:35%;width:45%;"></div>
As it looks, every time another crop variant is selected, the latest <div class="cropper-cover-area"> is removed, and the new ones added. Seems, more than one cropper-cover-area is not removed, although multiple are defined.
Updated by Chris Müller 9 months ago
- Subject changed from coverAreas seem to be merged for different cropVariants to Multiple configured coverAreas not correctly displayed in image manipulation modal
Updated by Chris Müller 9 months ago
· Edited
I assume, this line is responsible:
this.cropBox?.querySelector(this.coverAreaSelector)?.remove();
https://github.com/TYPO3/typo3/blob/12.4/Build/Sources/TypeScript/backend/image-manipulation.ts#L493
With querySelector only one cover area is removed from DOM? Using querySelectorAll and iterating over the results may be the fix.
Updated by Gerrit Code Review 6 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489
Updated by Gerrit Code Review 6 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489
Updated by Gerrit Code Review 6 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489
Updated by Gerrit Code Review 5 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489
Updated by Gerrit Code Review 5 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84837
Updated by Anonymous 5 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b054582569e4dece5cd576477671e090a4f21954.
Updated by Gerrit Code Review 5 months ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84837
Updated by Anonymous 5 months ago
- Status changed from Under Review to Resolved
Applied in changeset 0f64c4ebfc7a1132d163147c203ea04db561675b.
Updated by