Project

General

Profile

Actions

Task #103605

closed

Enable corrected test for default value parsing

Added by Stefan Bürk 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2024-04-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Test covering the SQL file parser has been streamlined
and enriched with #103602, adding a disabled test with
a todo to enable it with the corresponding bugfix.

Mentally missleaded, the disabled test itself is not
correct based on the fact that MySQL and MariaDB use
single quotes to quote single quotes in values like

DEFAULT 'some value with a '' (single quote)'

instead of the assumed `\'` variant.

Further studies revealed that the prehistoric parser
is more than capable to properly parse this form of
default values.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #103602: Streamline Schema Parser testClosedStefan Bürk2024-04-11

Actions
Actions #1

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83746

Actions #2

Updated by Stefan Bürk 8 months ago

  • Related to Task #103602: Streamline Schema Parser test added
Actions #3

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83746

Actions #4

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83754

Actions #5

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83754

Actions #6

Updated by Stefan Bürk 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF