Project

General

Profile

Actions

Bug #103626

closed

UX: Backend Page Module - hidden Content Elements are not hidden if 'Show hidden content elements' is disabled

Added by Ayke Halder 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2024-04-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
UX
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In Page Module the hidden Content Elements are not hidden anymore if 'Show hidden content elements' is disabled.

Additionally hidden elements must not be accessible/focusable by keyboard.

Regression


Files


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #103381: UX: Backend Page Module - box-shadow on Content ElementsResolved2024-03-12

Actions
Actions #1

Updated by Ayke Halder 2 months ago

  • Related to Bug #103381: UX: Backend Page Module - box-shadow on Content Elements added
Actions #2

Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #3

Updated by Ayke Halder 2 months ago

  • Subject changed from Backend Page Module - hidden Content Elements are not hidden if 'Show hidden content elements' is disabled to UX: Backend Page Module - hidden Content Elements are not hidden if 'Show hidden content elements' is disabled
  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #5

Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #7

Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #8

Updated by Ayke Halder 2 months ago ยท Edited

If the URLs anchor-part is set to the elements id, the element gets a scroll-correcting pseudo-element by CSS:
:target:before
This pseudo-element has a height which is countered by negative margin-top.
scrollHeight and height of the element are still influenced by this pseudo-element and the elements margin-top.

So in case you toggle the visible state of an element the url becomes:
https://typo3.ddev.site/typo3/module/web/layout?id=2#element-tt_content-5
Then switch the 'show hidden elements' checkbox and this element referenced by the URL-anchor behaves broken.

Fixed by using overflow: clip in combination with display: flow-root.

Actions #9

Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #10

Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #11

Updated by Ayke Halder 2 months ago

  • File deleted (clipboard-202404161621-4zxdv.png)
Actions #12

Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #13

Updated by Gerrit Code Review 2 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781

Actions #14

Updated by Ayke Halder 2 months ago

  • Tags set to UX
Actions #15

Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83974

Actions #16

Updated by Ayke Halder 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF