Project

General

Profile

Actions
Copy link

Task #103889

closed

PHPunit functional tests persist to much memory - use tearDown for crucial cases

Added by Ayke Halder about 1 month ago. Updated 13 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2024-05-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There are some crucial cases:

# TYPO3\CMS\Frontend\Tests\Functional\ContentObject\FilesContentObjectTest
!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!. 5063 / 7862 ( 64%)
!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.
Memory leak: 102.10 MB

# TYPO3\CMS\Core\Tests\Functional\DataHandling\DataHandler\SecurityTest
............  854 / 7862 ( 10%)
..................................
Memory leak: 101.25 MB

# TYPO3\CMS\Core\Tests\Functional\Imaging\IconFactoryTest
........... 2379 / 7862 ( 30%)
......................................
Memory leak: 73.90 MB

# TYPO3\CMS\Backend\Tests\Functional\Controller\MfaConfigurationControllerTest
!!!!.!!!!.   61 / 7862 (  0%)
!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.
Memory leak: 49.31 MB

# TYPO3\CMS\Extbase\Tests\Functional\Persistence\RelationTest
............. 3538 / 7862 ( 45%)
............................................................. 3599 / 7862 ( 45%)
............................
Memory leak: 54.30 MB

# TYPO3\CMS\Impexp\Tests\Functional\ExportTest
!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.
Memory leak: 30.69 MB

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Epic #103888: PHPunit functional tests persist to much memory - use tearDown etc. to fixResolved2024-05-23

Actions
Related to TYPO3 Core - Task #104127: Upgrade to phpunit ^11.2.2Resolved2024-06-17

Actions
Actions
Copy link
 #1

Updated by Ayke Halder about 1 month ago

  • Related to Epic #103888: PHPunit functional tests persist to much memory - use tearDown etc. to fix added
Actions
Copy link
 #2

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #3

Updated by Ayke Halder about 1 month ago

There is a base memory usage for tests of ~55 MB. Multiple tests run in one test-run will reuse this data.

So getting a single test run down to Memory leak: ~55 MB is as good as it gets.

For reporting tool see:
https://github.com/TYPO3/testing-framework/issues/561

Before

$ ./Build/Scripts/runTests.sh -s functional -p 8.2 -d mariadb typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php 

# TYPO3\CMS\Core\Tests\Functional\DataHandling\DataHandler\SecurityTest
..............................................                    46 / 46 (100%)
Memory leak: 153.53 MB

Time: 00:08.623, Memory: 169.00 MB

OK (46 tests, 92 assertions)

After

# TYPO3\CMS\Core\Tests\Functional\DataHandling\DataHandler\SecurityTest
..............................................                    46 / 46 (100%)
Memory leak: 55.74 MB

Time: 00:09.414, Memory: 99.00 MB

OK (46 tests, 92 assertions)

Before

$ ./Build/Scripts/runTests.sh -s functional -p 8.2 -d mariadb typo3/sysext/frontend/Tests/Functional/ContentObject/FilesContentObjectTest.php

# TYPO3\CMS\Frontend\Tests\Functional\ContentObject\FilesContentObjectTest
!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.!.        58 / 58 (100%)
Memory leak: 154.66 MB

Time: 00:15.984, Memory: 169.00 MB

OK (58 tests, 58 assertions)

After

# TYPO3\CMS\Frontend\Tests\Functional\ContentObject\FilesContentObjectTest
..........................................................        58 / 58 (100%)
Memory leak: 54.64 MB

Time: 00:16.977, Memory: 97.00 MB

OK (58 tests, 58 assertions)

Before

$ ./Build/Scripts/runTests.sh -s functional -p 8.2 -d mariadb typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php

# TYPO3\CMS\Core\Tests\Functional\Imaging\IconFactoryTest
.................................................                 49 / 49 (100%)
Memory leak: 126.33 MB

Time: 00:02.819, Memory: 141.00 MB

OK (49 tests, 57 assertions)

After

# TYPO3\CMS\Core\Tests\Functional\Imaging\IconFactoryTest
.................................................                 49 / 49 (100%)
Memory leak: 55.75 MB

Time: 00:03.139, Memory: 101.00 MB

OK (49 tests, 57 assertions)

Before

$ ./Build/Scripts/runTests.sh -s functional -p 8.2 -d mariadb 

# TYPO3\CMS\Backend\Tests\Functional\Controller\MfaConfigurationControllerTest
!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.!!!!.                                            22 / 22 (100%)
Memory leak: 102.21 MB

Time: 00:03.727, Memory: 117.00 MB

OK (22 tests, 68 assertions)

After

# TYPO3\CMS\Backend\Tests\Functional\Controller\MfaConfigurationControllerTest
......................                                            22 / 22 (100%)
Memory leak: 56.75 MB

Time: 00:03.549, Memory: 99.00 MB

OK (22 tests, 68 assertions)

Before

$ ./Build/Scripts/runTests.sh -s functional -p 8.2 -d mariadb typo3/sysext/impexp/Tests/Functional/ExportTest.php

# TYPO3\CMS\Impexp\Tests\Functional\ExportTest
!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.!!.                                                    14 / 14 (100%)
Memory leak: 86.28 MB

Time: 00:05.008, Memory: 103.00 MB

OK (14 tests, 25 assertions)

After

# TYPO3\CMS\Impexp\Tests\Functional\ExportTest
!.!.!.!.!.!.!.!.!.!.!.!.!.!.                                                    14 / 14 (100%)
Memory leak: 58.77 MB

Time: 00:04.508, Memory: 103.00 MB

OK (14 tests, 25 assertions)
Actions
Copy link
 #4

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #5

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #6

Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #7

Updated by Gerrit Code Review about 1 month ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #8

Updated by Gerrit Code Review about 1 month ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #9

Updated by Gerrit Code Review about 1 month ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #10

Updated by Gerrit Code Review about 1 month ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84376

Actions
Copy link
 #11

Updated by Gerrit Code Review 13 days ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84732

Actions
Copy link
 #12

Updated by Christian Kuhn 13 days ago

  • Status changed from Under Review to Closed

resolved with younger phpunit versions.

Actions
Copy link
 #13

Updated by Ayke Halder 13 days ago

Actions
Copy link

Also available in: Atom PDF