Project

General

Profile

Actions

Bug #104191

closed

A call to TYPO3\CMS\Core\Page\AssetCollector->addStyleSheet() is interpreted incorrectly

Added by Stephan Kellermayr 5 months ago. Updated 5 months ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2024-06-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

A call to $assetCollector->addStyleSheet() triggers the following issues in "Scan Extension Files":
  • Deprecation: #85735 - Various method and property in DocumentTemplate
  • Breaking: #87193 - Deprecated functionality removed

This seems to be wrong, because TYPO3\CMS\Core\Page\AssetCollector->addStyleSheet() is not related to TYPO3\CMS\Backend\Template\DocumentTemplate->addStyleSheet() .

Actions #1

Updated by Christian Kuhn 5 months ago

False positives are part of the nature of the extension scanner, as explained here:

https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/HowTo/UpdateExtensions/ExtensionScanner.html

Non-static matches are thus always marked as "weak" matches.

In this case, I'd say it's ok to keep that matcher entry (the option is to remove it).

I tend to reject the issue. I that ok with you?

Actions #2

Updated by Stephan Kellermayr 5 months ago

Thanks Christian, that's OK for me, I can live with it. I'm just wondering whether it will be so obvious to others who use my extension ...?

Christian Kuhn wrote in #note-1:

I tend to reject the issue. I that ok with you?

Actions #3

Updated by Stephan Kellermayr 5 months ago

Ah, I just saw that there is an option @extensionScannerIgnoreFile that I can use to prevent this (which seems legitimate in this case, since it is actually a false positive).

Actions #4

Updated by Christian Kuhn 5 months ago

  • Status changed from New to Rejected
Actions #5

Updated by Christian Kuhn 5 months ago

Cool. Thanks for quick feedback!

Actions

Also available in: Atom PDF