Project

General

Profile

Actions

Bug #104233

open

PHP Warning: Undefined array key "minitems" for editors with no permissions to sys_file_reference

Added by Georg Ringer 3 days ago. Updated 3 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
Backend User Interface
Start date:
2024-06-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Setting up an editor to allow tt_content but not sys_file_references leads to a strange error

PHP Warning: Undefined array key "minitems" in /var/www/html/typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php line 169

Problematic code

 $this->fileReferenceData['config'][$formFieldIdentifier . '-' . self::FILE_REFERENCE_TABLE] = [
            'min' => $config['minitems'],
            'max' => $config['maxitems'],
            'sortable' => $config['appearance']['useSortable'] ?? false,
            'top' => [
                'table' => $top['table'],
                'uid' => $top['uid'],
            ],
            'context' => [
                'config' => $configJson,
                'hmac' => $this->hashService->hmac($configJson, 'FilesContext'),
            ],
        ];

The reason is simple: \TYPO3\CMS\Backend\Form\FormDataProvider\TcaFiles does early checks if the user doesn't have access and if not, no default min/max items are initialized

Actions #1

Updated by Gerrit Code Review 3 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84944

Actions #2

Updated by Gerrit Code Review 3 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84944

Actions

Also available in: Atom PDF