Bug #104347
closedTYPO3 v12.4.17: ModifyLoginFormViewEvent requires new parameter
0%
Description
The latest bugfix release for TYPO3 introduced a change to felogin ModifyLoginFormViewEvent.
The event's constructor now requires a second parameter in constructor.
https://github.com/TYPO3-CMS/felogin/blob/v12.4.17/Classes/Event/ModifyLoginFormViewEvent.php#L30
Third-party extensions constructing and dispatching the event will now require adjustments in order to work with the new bugfix release.
Updated by Georg Ringer 4 months ago
- Status changed from New to Needs Feedback
why this is a potential regression? extensions should not initialize the event themselves and in logincontroller this->request should always be filled?
Updated by Georg Ringer 4 months ago
- Status changed from Needs Feedback to Closed
Hey!
I am closing the issue because lack of feedback. feel free to contact me via slack if you still find this is an issue
Updated by Mario Lubenka 4 months ago ยท Edited
Georg Ringer wrote in #note-1:
why this is a potential regression? extensions should not initialize the event themselves and in logincontroller this->request should always be filled?
We're using a custom LoginController to handle login via AJAX, as TYPO3 core LoginController only provides HTML output.
Moreover, ModifyLoginFormViewEvent is part of the public API, so I don't think it should introduce mandatory new arguments in a bugfix release.