Project

General

Profile

Actions

Task #104414

open

Sortable select items: JS - allow for button-tags and remove dead code

Added by Ayke Halder about 7 hours ago. Updated about 5 hours ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2024-07-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The current implementation only allows a-tags/HTMLAnchorElement
This adds button-tags/HTMLButtonElement
Actually right now there is no implication of defining either one, as the defined types do not become part of the generated JS-code.

Also some dead code that had no functional implication is removed:
event.target.closest('.t3js-btn-option') already implies the element itself , so no need to check for e.target.matches('.t3js-btn-option')


Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Bug #102783: Labeling of the SelectMultipleSideBySideElement select options is insufficientUnder Review2024-01-08

Actions
Actions #1

Updated by Ayke Halder about 7 hours ago

  • Related to Bug #102783: Labeling of the SelectMultipleSideBySideElement select options is insufficient added
Actions #2

Updated by Gerrit Code Review about 6 hours ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85279

Actions #3

Updated by Gerrit Code Review about 5 hours ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85279

Actions #4

Updated by Gerrit Code Review about 5 hours ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85279

Actions

Also available in: Atom PDF