Project

General

Profile

Actions

Bug #104682

open

Streamline checkbox and radio rendering - irregular nesting of radio-inputs

Added by Ayke Halder 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2024-08-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The checkboxes and radio-inputs were streamlined in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/78547

However there is a difference how the label-input nesting is implemented now.
I marked if the nesting was changed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/78547


typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.html:
Nesting unchanged.

        <div class="form-check">
            <label class="… form-check-label">
                <f:form.checkbox />
                <span>LABEL</span>
            </label>
        </div>

typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/Checkbox.html:
Nesting unchanged.

        <div > <!-- (<-- via Field/Field.html) -->
            <label >
                <f:form.checkbox />
                <span >LABEL</span>
            </label>
        </div> <!-- (<-- via Field/Field.html) -->

typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.html:
Nesting unchanged.

                <div class="form-check">
                    <label class="form-check-label">
                        <f:form.checkbox />
                        <span>VALUE</span>
                    </label>
                </div>

typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/MultiCheckbox.html:
Nesting unchanged.

                    <div >
                        <label >
                            <f:form.checkbox />
                            <span >VALUE</span>
                        </label>
                    </div>

typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html:
Nesting changed.

                        <div class="form-check">
                            <f:form.radio  id="{element.uniqueIdentifier}-{idIterator.index}" class="… form-check-input" />
                            <label class="form-check-label" for="{element.uniqueIdentifier}-{idIterator.index}">VALUE</label>
                        </div>

typo3/sysext/form/Resources/Private/FrontendVersion2/Partials/RadioButton.html:
Nesting unchanged.

                    <div >
                        <label >
                            <f:form.radio />
                            <span >VALUE</span>
                        </label>
                    </div>

Whats the intended nesting of label-input for radio-inputs?
Does typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html need to be reverted to the old nesting?


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100537: Streamline checkbox and radio renderingClosed2023-04-08

Actions
Actions #1

Updated by Ayke Halder 3 months ago

  • Related to Task #100537: Streamline checkbox and radio rendering added
Actions #2

Updated by Ayke Halder 3 months ago

  • Description updated (diff)
Actions

Also available in: Atom PDF