Project

General

Profile

Actions

Bug #104959

closed

typo3/cms-sys-note depends on typo3/cms-dashboard

Added by Rafael Kähm about 1 month ago. Updated 3 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Dashboard
Target version:
Start date:
2024-09-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.2
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The main branch on aac4f7be152b043b1a85b333b6fa03e2a67eabc0 fails with:

Uncaught TYPO3 Exception Invalid service "dashboard.widget.sys_notes.all": class "TYPO3\CMS\Dashboard\Widgets\WidgetInterface" not found while loading "TYPO3\CMS\SysNote\Widgets\PagesWithInternalNote".
thrown in file /var/www/html/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php
in line 177

The class TYPO3\CMS\SysNote\Widgets\PagesWithInternalNote uses/imports TYPO3\CMS\Dashboard\*.


Please add the dashboard to sys-note as dependncy.

Related: #104844


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #104844: Dashboard - sys_note - Add widgets for listing all the sys_notes inside the TYPO3 systemClosed2024-09-06

Actions
Actions #1

Updated by Rafael Kähm about 1 month ago

  • Related to Feature #104844: Dashboard - sys_note - Add widgets for listing all the sys_notes inside the TYPO3 system added
Actions #2

Updated by Garvin Hicking about 1 month ago

  • Category changed from composer to Dashboard
Actions #3

Updated by Garvin Hicking about 1 month ago

  • Status changed from New to Accepted

Thanks, this is an important catch! I believe adding a hard dependency here isn't the solution; we'd possible better register the dashboard widgets with a dependency check, like EXT:seo does in it's Configuration/Services.php file.

Actions #4

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86089

Actions #5

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86089

Actions #6

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86089

Actions #7

Updated by Garvin Hicking about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack 3 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF