Project

General

Profile

Actions
Copy link

Bug #105266

open

Sitemap Cache Bug on missing chash

Added by Andreas Gröf 4 months ago. Updated 22 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Site Handling, Site Sets & Routing
Target version:
-
Start date:
2024-10-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When Caching the Sitemap, get-Params seem to be ignored if no cHash is given. Which can result in a wrong Sitemap rendered.

1. Clear the Cache
2. Call a Subpage of your Sitemap without chash e.g. /sitemap.xml?sitemap=pages or ?type=1533906435&sitemap=pages (without RouteEnhancer)
3. Call the Sitemaps Index Page (/sitemap.xml or ?type=1533906435)

-> The Subpage will be shown instead of the Index-Page

Only tested in TYPO3 12

Actions
Copy link
 #1

Updated by Moritz Ngo 4 months ago

I could confirm this behavior in several different TYPO3 CMS installations.

I'm not sure if this issue is related to EXT:seo's XML sitemap or even larger to the general page rendering. I haven't enough time to investigate any further but to reproduce this behavior.

Actions
Copy link
 #2

Updated by Garvin Hicking 4 months ago

  • Category set to Site Handling, Site Sets & Routing

(Setting a category; unsure if it's right, but maybe Routijg fits better than ext:seo?)

Actions
Copy link
 #3

Updated by Andreas Gröf 4 months ago

Now I had a bit of time investigating.
The Problem is, that queryParams are ignored in Caching, when no cHash is given.
But im not sure what should be the correct behavior.

vendor/typo3/cms-frontend/Classes/Controller/TypoScriptFrontendController.php Line 1130

 protected function getRelevantParametersForCachingFromPageArguments(PageArguments $pageArguments): array
    {
        $queryParams = $pageArguments->getDynamicArguments();
        if (!empty($queryParams) && ($pageArguments->getArguments()['cHash'] ?? false)) {
            $queryParams['id'] = $pageArguments->getPageId();
            return GeneralUtility::makeInstance(CacheHashCalculator::class)
                ->getRelevantParameters(HttpUtility::buildQueryString($queryParams));
        }
        return [];
    }

Actions
Copy link
 #4

Updated by Gerrit Code Review 26 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87785

Actions
Copy link
 #5

Updated by Gerrit Code Review 26 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87785

Actions
Copy link
 #6

Updated by Gerrit Code Review 24 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87785

Actions
Copy link
 #7

Updated by Gerrit Code Review 22 days ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87785

Actions
Copy link

Also available in: Atom PDF