Project

General

Profile

Actions

Bug #105592

open

The TypoScript option "external" must be evaluated before an external CSS/JS resource gets included

Added by Josef Glatz 26 days ago. Updated 25 days ago.

Status:
Under Review
Priority:
Must have
Assignee:
Category:
TypoScript
Target version:
-
Start date:
2024-11-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
includeCSS, includeCSSLibs, includeJS, includeJSLibs
Complexity:
Is Regression:
Sprint Focus:

Description

Problem/Description

In https://review.typo3.org/c/Packages/TYPO3.CMS/+/27130 the functionality was removed. Looks like the regression exists for about 10 years

Example:

- page.includeCSS.1 must be included
- page.includeCSS.2 must NOT be included

  page.includeCSS {
    1 = https://unpkg.com/open-props
    2 = https://unpkg.com/open-props/normalize.min.css
    1.external = 1
    2.external = 0
  }

page.includeCSS.2 gets also included without applying any patch to the TYPO3 core.

ToDo(s)

  • Re-add check if the url to js/css resource begins with https, http or // and only include it if external option is set.

Acceptance Criteria

  • The external JS/CSS includes must work like it was before some time ago
  • The external JS/CSS includes must work like it is documented (Link to documentation)
Actions #1

Updated by Gerrit Code Review 26 days ago

  • Status changed from New to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86983

Actions #2

Updated by Josef Glatz 26 days ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review 25 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86983

Actions #4

Updated by Josef Glatz 25 days ago

  • Description updated (diff)
Actions #5

Updated by Josef Glatz 25 days ago

  • Description updated (diff)
Actions #6

Updated by Josef Glatz 25 days ago

  • Description updated (diff)
Actions

Also available in: Atom PDF