TYPO3 Core

Thanks for your fast response. We're using the core QueryBuilder, created by:

$qb = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('tablename');

Indeed it works if we manually add a string-cast in front of the query-builder object.
Is this meant to be like this, or should toString() called automatically?

->from('fe_users', 'u')
->leftJoin('u', 'example', 'e', (string)$qb->expr()->andX(
    $qb->expr()->eq('u.uid', 'e.fe_users_uid'),
    $qb->expr()->eq('e.field', 1),
))

You're welcome :)

In fact, yes - the T3v11 core did this using (string) too:

https://github.com/TYPO3/typo3/blob/054dda798e88a28f97df6b3b84ea2cc0fb425c7a/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php#L1015

(Please note in TYPO3v12+, the andX() methods are replaced with simple and() methods, but the string cast remains).

If that's ok with you, I would close the ticket?

All right, if the core use the string-cast too, we'll consider it as best-practice ;-)

I was just wondering, because everything becomes more and more type-save. So inside the join() method it would be easy to check if the given parameter is an object of type CompositeExpression (or ExpressionBuilder?!) and just call toString() in this case.

Anyway, casting is fine, just have to remember this case. Maybe a hint or example in the docs make sense. I mean, the current example (https://docs.typo3.org/permalink/t3coreapi:ApiOverview/Database/QueryBuilder/Index#join-innerjoin-rightjoin-and-leftjoin) could be easily extended by adding an and() condition as 4th parameter in this join(). But its extra-sugar.

(Please note in TYPO3v12+, the andX() methods are replaced with simple and() methods, but the string cast remains).
If that's ok with you, I would close the ticket?

Highly appreciate your feedback! 🙏🏼 And yes, you can close it.