Bug #12226
closed
Website that has multiple domainsrecords produces funny links
Added by Olivier Dobberkau almost 14 years ago.
Updated almost 11 years ago.
Description
I have a website with a multidomain setup with one three only.
If i try to check links i get the report like this;
Path Element Link URL / Link Target Error message Last check
/www.typo3-solr.com/Seite nicht gefunden/ Ihre gewünschte Seite konnte leider nicht gefunden werden! (Field: Text) Volltextsuche http:///index.php?id=7 Page 'Suche' (7) is deleted. 14.01.11 17:37
/www.typo3-solr.com/What is Solr/ What is Apache Solr? (Field: Text) Functions of Apache Solr http:///index.php?id=194 Page 'News' (194) is deleted. 14.01.11 17:37
seems like the domainrecord is missing and urls are not taking care of installed realurl
http:///index.php?id=194
Files
- File 12226.diff 12226.diff added
- Status changed from New to Needs Feedback
- Assignee set to Michael Miousse
here is a patch tha should correct domain name in links for the report info moudle
i have tested with multiple domain and it worked fine
OK. Applied the patch. This fixes the missing Domain stuff.
No cigar yet. now it says:
Path Element Link URL / Link Target Error message Last check
/www.typo3-solr.com/Home/ Einleitungstext (Field: Text) Facettierte Suche http://www.typo3-solr.com/index.php?id=651 Page (651) does not exist. 14.01.11 21:35
if i open the element containing the link:
<p>Apache Solr für TYPO3 ist eine Suchmaschine, die mehr kann. Nutzen Sie speziellen Features wie die <a href="http://www.typo3-solr.com/?id=254#651">Facettierte Suche</a> oder die <a href="http://www.typo3-solr.com/?id=247#738">Synonym Suche</a> und finden Sie die Anwort auf das Gesuchte schon nach Milisekunden.</p>
i see that it takes the stuff behind the # anchor as link...
Olivier Dobberkau wrote:
looks like #10989
yeah this is exactly the so you confirm that this one is solved?
this solves the missing domain problem under multiple domains. but i am not sure if this
return $domain . '/index.php?id=' . $row['url'];
is really good style. maybe someone could have a look on how to build correct links with all params or realurl.
- Status changed from Needs Feedback to Closed
- % Done changed from 0 to 100
- Status changed from Closed to Resolved
should have been resolved instead of closed
- Status changed from Resolved to Needs Feedback
Hi Michael,
this patch produces a problem:
I tested this on a page without any special domain records.
For internal links no domain is returned. $domain only holds "http://", but nothing more.
In my case "count($rootLine)" is 3 or sometimes 4 and so "if (count($rootLine) > 0) {" is true. After that t3lib_BEfunc::firstDomainRecord($rootLine) returns nothing.
If it did not go into the "if(count(...))-condition, it would work for me. Then $domain would be correct.
Could you look into that again, Michael?
- Status changed from Needs Feedback to Resolved
Committed revision 42418.
work for multi site and nodomain site
- Status changed from Resolved to Closed
- Category set to Linkvalidator
- Project changed from 1510 to TYPO3 Core
- Category changed from Linkvalidator to Linkvalidator
Also available in: Atom
PDF