TYPO3 Core

Nice work!

About this snippet(s):

   $failure = t3lib_div::makeInstance(
        'Exception',
$GLOBALS['LANG']->sL('LLL:EXT:linkvalidator/locallang.xml:tasks.error.invalidFromEmail'),
        t3lib_FlashMessage::ERROR
    );
    throw $failure;
    $sendEmail = FALSE;

1) throughout the core we usually use "throw new Exception()" syntax (no t3lib_div::makeInstance and no variable holding the exception before throwing it. Reasoning is that an exception should be thrown without relying on any other classes.

2) The second parameter of the Exception is not the FlashMessage Error-Code, but a unique unix timestamp (the time when you created the error message), so that we can differenciate different exceptions later on based on that information.

3) $sendEmail is never reached, so can also be removed (its shown as a "warning" in PhpStorm)

Could you adapt that still? Thanks!

Will do

The timestamp should be the time from now. Just as a hardcoded string like: 1295471588

But use 3 different timestamps for the 3 different messages.

Christopher wrote:

The timestamp should be the time from now. Just as a hardcoded string like: 1295471588

But use 3 different timestamps for the 3 different messages.

time() is not good?

Michael Miousse wrote:

time() is not good?

No, because the timestamp should be used to identify each error message. Therefore it must always be the same for the same message (but different for every other message).

Michael Miousse wrote:

okay here it is

sorry i forgot to erase path from the patch

Committed revision 42365.