Project

General

Profile

Actions
Copy link

Bug #14391

closed

fasten up if clause class t3lib_stdGraphic in function imageMagickConvert

Added by old_root old_root about 20 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Ingmar Schlecht
Category:
Backend API
Target version:
-
Start date:
2004-11-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.7.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I was searching for an error in different files, and while searching I found this row in class t3lib_stdGraphic in function imageMagickConvert

if (!$this->file_exists_typo3temp_file($output,$imagefile) || $this->dontCheckForExistingTempFile) {
$this->imageMagickExec($imagefile.$frame,$output,$command);
}

this could be better

if ($this->dontCheckForExistingTempFile || !$this->file_exists_typo3temp_file($output,$imagefile)) { ...

because if will not proof it the file exists if it doesn't matter, and
an sql select fewer is done.

New line should be :

if ($this->dontCheckForExistingTempFile || !$this->file_exists_typo3temp_file($output,$imagefile)){
(issue imported from #M508)

Actions
Copy link

Also available in: Atom PDF