Feature #14581
closed
FrontendEdit: forceDisplayIcons and admPanel.edit not open
0%
Description
1) Use Frontend-Editing
2) Set forceDisplayIcons via User-TSConfig
3) moving records up/down, hiding or deleting does not work unless you open the edit-section of the adminPanel or the adminPanel is hidden.
The attached patch fixes that behaviour and allows moving,hiding and deletion if forceDisplayIcons is set regardless of the status(open/close) of the edit-section of the adminPanel.
still enable.edit=1 or enable.all=1 is required!
That probably should be changed as well? so one could:
a) force the Icons to show
b) show the adminPanel
c) dont display the edit-section(cause it is unecessary/not needed)
(issue imported from #M849)
Files
Updated by Michael Stucki over 19 years ago
forceDisplayIcons.diff should do the trick even if enable.edit is not set (though untested).
Is there a problem with this? What do you think takes precedence?
- enable.edit (if it's set, editing is enabled, so if it's not set, it should be the opposite!)
- or forceDisplayIcons (one could think this implies enabling the edit mode as well)
I'm not sure yet. (In any case, the documentation should be updated (by you?) so that this is clarified.
Updated by Peter Niederlag over 19 years ago
I definitly think forceDisplayIcons should take precedence.
At least the folks I talked to expected this to imply enabling the edit mode also.
To my concern enable.edit rather seems to be a GUI-setting(display the edit-section of admPanel) than any checking of permissions or restriction of operation-modus.
.diff looks good to me, we'll have a try....
Updated by Michael Stucki over 19 years ago
Fixed in CVS (3.8)
About the precedence:
When I asked Kasper he pointed to the TSconfig document.
It says: "Forces edit-panels to appear regardless of the selectorbox."
So yes it is right to let this have precedence.
- michael