Bug #14795
closed
JS Error with JSMENU
0%
Description
When no <base> tag is set in a page containing a JSMENU then an JS Error occurs in Firefox 1.0.3 when selecting a select-box entry.
The line in question is:
if (document.getElementsByTagName("base")[0].href != "") {
The problem is if there is no Tag named "base" then the .href operator will fail.
I attached a solution as unified diff .
(issue imported from #M1167)
Files
Updated by Zach Davis over 18 years ago
I think you're missing a closing paranthesis on the IF statement in the diff.
--Zach
Updated by Thomas Hempel over 18 years ago
Thanks a lot... It works fine for me. :-) (I used the complete jsfunc.menu.js and not the patch)
Greets,
Thomas
Updated by Sebastian Kurfuerst over 18 years ago
Hi,
is it possible for you to create a test pagetree export file to validate the patch?
Greets, Sebastian
Updated by Thomas Hempel over 18 years ago
Here is a very simple pagetree for testing
Updated by Sebastian Kurfuerst over 18 years ago
I just checked the code, and IMO, the bug doesn't exist anymore in CVS. I have uploaded a new jsfunc.menu.js, please verify this.
Greets, Sebastian
Updated by Thomas Hempel over 18 years ago
Hi,
I can confirm, that the JSMENU works with the current CVS version of the core.
Greets,
Thomas
Updated by Sebastian Kurfuerst over 18 years ago
this bug was already resolved in CVS.