Project

General

Profile

Actions
Copy link

Bug #14819

closed

htmlspecialchars called multiple times

Added by Johannes Bornhold over 19 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Michael Stucki
Category:
Indexed Search
Target version:
-
Start date:
2005-06-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In the class.tx_indexedsearch.php there are multiple situations where the output is processed by htmlspecialchars multiple times which results in output like "

My solution was to remove one of the duplicates.

(issue imported from #M1199)

Files

Download all files
out.txt (1.71 KB) out.txt Administrator Admin, 2005-06-15 12:26
class.tx_indexedsearch.php (91.1 KB) class.tx_indexedsearch.php Administrator Admin, 2005-09-17 17:22
indexedTitle_htmlspecialchars.diff (760 Bytes) indexedTitle_htmlspecialchars.diff Administrator Admin, 2006-01-16 11:45
Actions
Copy link
 #1

Updated by Johannes Bornhold over 19 years ago

Added some excerpts from the file pi/class.tx_indexedsearch.php. Hope this helps.

Actions
Copy link
 #2

Updated by Ingo Schmitt about 19 years ago

Working Version attached, just changed prepareResultRowTemplateData line 1472 to $title = $this->linkPage($row['data_page_id'],($this->makeTitle($row)),$row,$markUpSwParams);

Actions
Copy link
 #3

Updated by Ingo Schmitt about 19 years ago

Uploaded wrong file, sorry, last one is the right one

Actions
Copy link
 #4

Updated by René Wagner almost 19 years ago

Ugly result: If a page title contains an ampersand (not too rarely), the twice parsing makes the entity visible &. Other specialchars should not used as often.

Actions
Copy link
 #5

Updated by old_zas almost 19 years ago

still not fixed in last version.

Actions
Copy link
 #6

Updated by Michael Stucki almost 19 years ago

Funny enough I just sent a patch for this to the core list 5 minutes ago! :-)

Actions
Copy link
 #7

Updated by Michael Stucki almost 19 years ago

See uploaded patch.

Actions
Copy link
 #8

Updated by old_zas almost 19 years ago

Great ;)

Actions
Copy link
 #9

Updated by old_zas almost 19 years ago

It fixes it on version 3.8.1. Thanks.

Actions
Copy link
 #10

Updated by René Wagner almost 19 years ago

Whats with this part:

class.tx_indexedsearch.php,v 1.15.2.1
1929: $pathStr = htmlspecialchars($this->getPathFromPageId($pathId,$pathMP));
1930: $tmplArray['path'] = $this->linkPage($pathId,htmlspecialchars($pathStr),array(

Actions
Copy link
 #11

Updated by Michael Stucki almost 19 years ago

Thanks, René - I've changed this as well.

Actions
Copy link
 #12

Updated by Michael Stucki almost 19 years ago

Fixed in CVS

Actions
Copy link

Also available in: Atom PDF