Project

General

Profile

Actions

Bug #15182

closed

new similar Option to HMENU includeNotInMenu

Added by Marc Bastian Heinrichs over 18 years ago. Updated over 17 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-11-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8.0
PHP Version:
5
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

We have the "Hide in Menu" property for any page type, but there is no option for HMENU to include menu-hidden pages in a special menu, like includeNotInMenu for the pagetype 'Not in Menu'.

(issue imported from #M1794)


Files

bug_1794.patch (1.45 KB) bug_1794.patch Administrator Admin, 2005-11-19 09:11

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #15183: HMENU with includeNotInMenu does not work with nav_hide = 1ClosedWolfgang Klinger2005-11-07

Actions
Actions #1

Updated by tob over 18 years ago

that should work by setting excludeDoktypes, see http://typo3.org/documentation/document-library/doc_core_tsref/HMENU/

Actions #2

Updated by Sebastian Kurfuerst over 18 years ago

I think as well that this can be done like tob outlined. If not, please reopen the bug report.
Greets, Sebastian

Actions #3

Updated by Marc Bastian Heinrichs over 18 years ago

I don't want to exclude other doktypes from menus, which is done by excludeDoktypes.

I think, it's useful to have the TS-option for an HMENU to include pages, where the option "Hide in menu" is set.
This is currently done by the TS-option includeNotInMenu for pages with the pagetype 'Not in menu', but don't work with option "Hide in menu".

Actions #4

Updated by tob over 18 years ago

ok confirmed..
following menu shows only pages with the doctype "not in menu", but not "hide in menu" (hide in menu sets nav_hide=1 in pages and this is hardcodet in class.tslib_menu.php
eg:
$extraWhere = ' AND pages.nav_hide=0'.$this->getDoktypeExcludeWhere();
)
temp.menu=HMENU
temp.menu.includeNotInMenu=1
temp.menu.excludeDoktypes=5
temp.menu.1=TMENU
temp.menu.1.NO {
allWrap = | >>
}

I also wondered why there are 2 possibilities to hide a page .. maybe for eg. mailform confirm/thank you pages which you really dont want to have in a menu

Actions #5

Updated by Marc Bastian Heinrichs over 18 years ago

I think the option "Hide in menu" was implemeted later and now the Pagetype 'Not in menu' is obsolete.

http://bugs.typo3.org/view.php?id=1150
http://bugs.typo3.org/view.php?id=1062

Actions #6

Updated by Sebastian Kurfuerst over 18 years ago

basheinr: Yes, you are right. The pagetype "not in menu" will most likely be removed in 4.0 and replaced by the nav_hide setting during the update.
Greets, Sebastian

Actions #7

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
the current patch modifies the behavior in a way that the pages with the "hide in menu" property are shown when includeNotInMenu is set.
Does this make sense?

It would be great if you could test the patch,
Greets, Sebastian

Actions #8

Updated by Marc Bastian Heinrichs over 18 years ago

Hi Sebastian,
I've tested tes patch and it doesn't work, sorry.
I looked at the source and I think your changes applies only to HMENU special 'updated' and 'keywords'. In function filterMenuPages pages with 'nav_hide' set don't get into the menu.
In function generate_level of class tslib_jsmenu the nav_hide options is also used.

greets, Marc Bastian

Actions #9

Updated by Sebastian Kurfuerst over 18 years ago

I think you are right - however I don't have time to provide a new patch at the moment. Will look at this later.
Greets, Sebastian

Actions #10

Updated by Marc Bastian Heinrichs about 18 years ago

fixed in #15183

Actions

Also available in: Atom PDF